Re: [Qemu-devel] Re: [PATCH 5/6] tcg-i386: Simplify brcond2.

[Richard Henderson]

On 12/18/2009 03:40 AM, Laurent Desnogues wrote:
> I'm not sure I really like that rewrite, I find it hard to read.
> Convince me it's better :-)

Would it be more obvious if I used a table instead of a switch?
The code size reduction is

   Num:    Value  Size Type    Bind   Vis      Ndx Name

before:
    40: 000039a0   793 FUNC    LOCAL  DEFAULT    1 tcg_out_brcond2
after:
    40: 00003a50   412 FUNC    LOCAL  DEFAULT    1 tcg_out_brcond2
table-ized:
    40: 00003a50   224 FUNC    LOCAL  DEFAULT    1 tcg_out_brcond2

But I'm not married to the patch; let's drop it if there's a question of 
it holding up the rest of the series.


r~