|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 5/7] tcg-sparc: Implement setcond, movcond, setcond2, brcond2. |
Date: | Sat, 19 Dec 2009 14:52:52 -0800 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
On 12/19/2009 01:25 PM, Blue Swirl wrote:
On Sat, Dec 19, 2009 at 5:47 PM, Richard Henderson<address@hidden> wrote:On 12/19/2009 02:31 AM, Blue Swirl wrote:static inline void tcg_out_movi_imm32(TCGContext *s, int ret, uint32_t arg) { - if (check_fit_tl(arg, 12)) + if (check_fit_tl(arg, 13)) tcg_out_movi_imm13(s, ret, arg);IIRC sign extension prevents this.Pardon? check_fit_tl checks a signed value, the OR opcode provides one. Where's the conflict?Long time ago I tried the same change, but the generated code was not correct. But now it seems to work.
I can't imagine why. I've looked at the instruction encodings very carefully and double-checked the arithmetic vs GCC.
I still think the change is correct. I can probably dig up access to a sparc machine and verify, but I don't know that would convince you.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |