[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE |
Date: |
Tue, 22 Dec 2009 21:12:20 +0000 |
On Sun, Dec 20, 2009 at 1:39 AM, Kirill A. Shutemov
<address@hidden> wrote:
> CC i386-softmmu/vl.o
> cc1: warnings being treated as errors
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment':
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of
> 'write', declared with attribute warn_unused_result
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'main':
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:5774: error: ignoring return value of
> 'write', declared with attribute warn_unused_result
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6064: error: ignoring return value of
> 'chdir', declared with attribute warn_unused_result
> /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:6083: error: ignoring return value of
> 'chdir', declared with attribute warn_unused_result
> make[1]: *** [vl.o] Error 1
>
> Signed-off-by: Kirill A. Shutemov <address@hidden>
> ---
> vl.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e606903..60a2c5e 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3383,7 +3383,11 @@ static void qemu_event_increment(void)
> if (io_thread_fd == -1)
> return;
>
> - write(io_thread_fd, &byte, sizeof(byte));
> + if (write(io_thread_fd, &byte, sizeof(byte)) != sizeof(byte)){
> + fprintf(stderr, "qemu_event_increment: write() filed: %s\n",
> + strerror(errno));
> + exit (1);
> + }
> }
>
> static void qemu_event_read(void *opaque)
> @@ -5767,7 +5771,8 @@ int main(int argc, char **argv, char **envp)
> #ifndef _WIN32
> if (daemonize) {
> uint8_t status = 1;
> - write(fds[1], &status, 1);
> + if (write(fds[1], &status, 1) != 1)
> + perror("write()");
> } else
> #endif
> fprintf(stderr, "Could not acquire pid file: %s\n",
> strerror(errno));
> @@ -6064,7 +6069,8 @@ int main(int argc, char **argv, char **envp)
> if (len != 1)
> exit(1);
>
> - chdir("/");
> + if (chdir("/"))
> + exit(1);
> TFR(fd = qemu_open("/dev/null", O_RDWR));
> if (fd == -1)
> exit(1);
> @@ -6083,7 +6089,8 @@ int main(int argc, char **argv, char **envp)
> fprintf(stderr, "chroot failed\n");
> exit(1);
> }
> - chdir("/");
> + if (chdir("/"))
> + exit(1);
Can't comment much on write() parts. chdir() checks are OK, except an
error message would be in order.
- [Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with _FORTIFY_SOURCE, (continued)
- [Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 12/18] savevm.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 13/18] slirp/misc.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 17/18] path.c fix warning with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- [Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE, Kirill A. Shutemov, 2009/12/19
- Re: [Qemu-devel] [PATCH 17/18] path.c fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 14/18] vl.c: fix warning with _FORTIFY_SOURCE,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 12/18] savevm.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 11/18] usb-linux.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings with _FORTIFY_SOURCE, Andreas Schwab, 2009/12/20
- Re: [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY_SOURCE, Kevin Wolf, 2009/12/20
- Re: [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
- Re: [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE, Paul Brook, 2009/12/20
Re: [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE, Blue Swirl, 2009/12/22
Re: [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE, Blue Swirl, 2009/12/20