Re: [Qemu-devel] [PATCH] PPC: Make DCR uint32_t

[Aurelien Jarno]

On Sun, Dec 27, 2009 at 09:34:26PM +0100, Alexander Graf wrote:
> 
> Am 27.12.2009 um 12:06 schrieb Stefan Weil <address@hidden>:
> 
> >Alexander Graf schrieb:
> >>For what I know DCR is always 32 bits wide, so we should also use
> >>uint32_t to
> >>pass it along the stacks.
> >>
> >>This fixes a warning when compiling qemu-system-ppc64 with KVM
> >>enabled, making
> >>it compile without --disable-werror
> >>
> >>Signed-off-by: Alexander Graf <address@hidden>
> >>---
> >>darwin-user/main.c | 4 ++--
> >>hw/ppc.c | 4 ++--
> >>hw/ppc.h | 4 ++--
> >>hw/ppc405_uc.c | 46 +++++++++++++++++++++++-----------------------
> >>hw/ppc4xx_devs.c | 14 +++++++-------
> >>linux-user/main.c | 4 ++--
> >>target-ppc/cpu.h | 4 ++--
> >>target-ppc/helper.h | 4 ++--
> >>target-ppc/op_helper.c | 10 +++++-----
> >>9 files changed, 47 insertions(+), 47 deletions(-)
> >
> >Hi,
> >
> >this patch (which was already applied to qemu master)
> >breaks builds with --enable-debug-tcg for all ppc64 targets:
> >
> > CC    ppc64-softmmu/translate.o
> >/home/stefan/src/qemu/repo.or.cz/qemu/ar7/target-ppc/translate.c: In
> >function ‘gen_mfdcr’:
> >/home/stefan/src/qemu/repo.or.cz/qemu/ar7/target-ppc/translate.c:5568:
> >error: incompatible type for argument 1 of ‘gen_helper_load_dcr’
> >/home/stefan/src/qemu/repo.or.cz/qemu/ar7/target-ppc/translate.c:5568:
> >error: incompatible type for argument 2 of ‘gen_helper_load_dcr’
> >...
> 
> Yes, the tcg helper call passes a cpu register as parameter to the
> helper function. That is tlong of course.
> 
> Now the function takes an i32 as parameter which makes the types not
> match. I haven't figured out yet if it'd be better to do the
> conversion in tcg using a temp register or in C by having a
> different helper exported that just calls the i32 function but takes
> tlongs.
> 

It's most probably better and faster to do the conversion in the helper.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net