|
From: | Alexander Graf |
Subject: | Re: [Qemu-devel] [PATCH 6/6] pci host: make pci_data_{write, read}() get PCIConfigAddress. |
Date: | Tue, 12 Jan 2010 18:54:00 +0100 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090817) |
Isaku Yamahata wrote: > Move out pci address decoding logic from pci_data_{write, read}() > by making pci_data_{write, read}() get PCIConfigAddress. > I think this is going in the wrong direction. You are keeping the device specific MMIO/PIO based config space access handlers and just move the address decoding into a separate function. The whole idea of my patch was to only use pci_host to handle the MMIOs and have a simple callback into a bus specific decoder. That way we could probably remove most of the functions you're patching in this patch. Or am I wrong here? Alex
[Prev in Thread] | Current Thread | [Next in Thread] |