Re: [Qemu-devel] [PATCHv2 1/3] qemu: memory notifiers

[Avi Kivity]

On 01/18/2010 05:45 PM, Michael S. Tsirkin wrote:
> cpu_register_physical_memory_offset already is O(memory size) btw.
>    

Right, but we'd like to replace it with a range API.

>    
> > > > Maybe we mandate clients be registered at init-time?
> > > >
> > > >          
> > > This might be tricky - vhost currently only registers when the
> > > first device is hot-added.
> > >
> > >        
> > I see.
> >
> > Maybe coalesce adjacent pages and call the callback with the ranges?
> >      
> Hmm, it turns out to be tricky: it seems whether we can do this
> really depends on what get_ram_ptr returns ...
> Can't we just rely on callback to do the coalescing?
>    

If the callback can do the coalescing, surely the caller can as well?

This way we don't introduce a new per-page API.

--
error compiling committee.c: too many arguments to function