[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters return value |
Date: |
Wed, 20 Jan 2010 11:02:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
Am 19.01.2010 19:58, schrieb Christoph Hellwig:
> On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote:
>> @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size)
>>
>> /* write new table (align to cluster) */
>> new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2);
>> + if (new_l1_table_offset < 0) {
>> + return new_l1_table_offset;
>> + }
>
> I think the error return needs to free new_l1_table first.
Right. Actually, I have found this bug already and included the fix in
patch 11/10 which contains the fix to the problem you found with patch 1
(however, I wasn't aware any more that I introduced it myself). Maybe I
should better respin the series instead of posting patch 11 on top.
Kevin
- [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount, (continued)
- [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount, Kevin Wolf, 2010/01/18
- [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write, Kevin Wolf, 2010/01/18
- [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts, Kevin Wolf, 2010/01/18
- [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters return value, Kevin Wolf, 2010/01/18
- [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value, Kevin Wolf, 2010/01/18