[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly at
From: |
Naphtali Sprei |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute |
Date: |
Thu, 21 Jan 2010 15:19:28 +0200 |
User-agent: |
Thunderbird 2.0.0.23 (X11/20090817) |
Christoph Hellwig wrote:
> Looking at the version of this that landed in git I don't think the
> read-only handling is entirely clean after this.
I fixed what I could, still I got some questions below.
>
> - we now normally set the read_only flag from bdrv_open2 when we do
> not have the O_RDWR flag set
> - but the block drivers also mess with it:
> o raw-posix superflously sets it when BDRV_O_RDWR is not in the
> open flags
Not sure where exactly is the issue. Can you please point the line ?
> o bochs, cloop, dmg and parallels set it unconditionally given
> that they do not support writing at all. But they do not
> bother to reject opens without BDRV_O_RDWR
I just changed bochs and parallels not to ask for read-write.
Should all of them test the flags for RDWR and returns failure ?
> o vvfat as usual is a complete mess setting and clearing it in
> various places
Fixed one occurance. More places ?
> - in addition to that bdrv_open2 also sets it after calling itself for
> the backing hd which seems superflous
Is this a problem ? I thought it's safer to mark it read-only, in case a write
operation requested somehow.
> - there also is a now unused bdrv_set_read_only helper to set it from
> outside block.c
Done. Removed.
>
>
Thanks,
Naphtali
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., (continued)
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Markus Armbruster, 2010/01/20
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Michael S. Tsirkin, 2010/01/20
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Markus Armbruster, 2010/01/20
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Michael S. Tsirkin, 2010/01/20
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Markus Armbruster, 2010/01/20
- Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Jamie Lokier, 2010/01/20
- [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE., Naphtali Sprei, 2010/01/18
Re: [Qemu-devel] [PATCH v2 1/4] Make CDROM a read-only drive, Jamie Lokier, 2010/01/19
Re: [Qemu-devel] [PATCH v2 1/4] Make CDROM a read-only drive, Anthony Liguori, 2010/01/20
Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute, Christoph Hellwig, 2010/01/20
- Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute,
Naphtali Sprei <=