|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support |
Date: | Fri, 22 Jan 2010 12:00:36 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 01/21/2010 03:09 PM, Luiz Capitulino wrote:
""" {"QMP": {"capabilities": ["async messages"]}} { "execute": "query-qmp-mode" } {"return": {"mode": "handshake"}} { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": "1234" } } {"error": {"class": "QMPInvalidModeCommad", "desc": "The issued command is invalid in this mode", "data": {}}} { "execute": "async_msg_enable", "arguments": { "name": "STOP" } } {"return": {}}
Maybe: enable-capability "async messages" disable-capability "async messages"I think that's a bit more obvious and it means that a client doesn't have to maintain a mapping of features -> enable functions. It's also strange to use an enable command to disable something.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |