[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it
From: |
Ben Taylor |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it |
Date: |
Wed, 27 Jan 2010 07:47:55 -0500 |
On Wed, Jan 27, 2010 at 7:10 AM, Loïc Minier <address@hidden> wrote:
> Check whether sdl-config is available before calling it, otherwise
> ./configure triggers a warning:
> ./configure: 957: sdl-config: not found
>
> If neither the .pc file not sdl-config are present, disable SDL support.
>
> Signed-off-by: Loïc Minier <address@hidden>
> ---
> configure | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 1f6de41..27ab724 100755
> --- a/configure
> +++ b/configure
> @@ -997,9 +997,14 @@ fi
> if $pkgconfig sdl --modversion >/dev/null 2>&1; then
> sdlconfig="$pkgconfig sdl"
> _sdlversion=`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g'`
> -else
> +elif which sdl-config >/dev/null 2>&1; then
> sdlconfig='sdl-config'
> _sdlversion=`$sdlconfig --version | sed 's/[^0-9]//g'`
> +else
> + if test "$sdl" = "yes" ; then
> + feature_not_found "sdl"
> + fi
> + sdl=no
> fi
>
> sdl_too_old=no
Glad to see someone working on Solaris. Wondering why you're using
the which command, when you just created a "has" function in the other
patch segments, and just replaced all the other instances of which.
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, (continued)
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure, Juan Quintela, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure, Måns Rullgård, 2010/01/21
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/26
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/26
- [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs, Loïc Minier, 2010/01/27
- [Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has(), Loïc Minier, 2010/01/27
- Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it,
Ben Taylor <=
- [Qemu-devel] Re: [PATCH 1/3] Check for sdl-config before calling it, Paolo Bonzini, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/27
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/28
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Blue Swirl, 2010/01/28
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Jamie Lokier, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/21
- [Qemu-devel] Re: Stop using "which" in ./configure, Juan Quintela, 2010/01/20
- [Qemu-devel] Re: Stop using "which" in ./configure, Paolo Bonzini, 2010/01/20
- Re: [Qemu-devel] Re: Stop using "which" in ./configure, Loïc Minier, 2010/01/20