[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option.

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option.
Date: Mon, 01 Feb 2010 10:49:29 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 02/01/2010 10:12 AM, Luiz Capitulino wrote:
On Mon, 01 Feb 2010 09:25:27 -0600
Anthony Liguori<address@hidden>  wrote:

On 02/01/2010 07:34 AM, Ian Molton wrote:
        Add a reconnect option that allows sockets to reconnect (after a
specified delay) to the specified server. This makes the virtio-rng driver
useful in production environments where the EGD server may need to be restarted.

Signed-off-by: Ian Molton<address@hidden>

I went back and looked at the last series and found my feedback.  I had
suggested that instead of automatically reconnecting, a mechanism should
be added for a user to initiate a reconnect.

Additionally, we should emit events upon disconnect through QMP (now
that we have that functionality).
  Should we merge all disconnect events or should we keep them

  I mean, we currently have VNC_DISCONNECT and will likely have
SPICE_DISCONNECT. Maybe we could have a SOCKET_DISCONNECT and have
a 'source' member, like:

Good question.

I'd suggest for now, keep them separate events. We can always merge them into a single event later and deprecate the old events. That will give us a better idea of what the data payload needs to be.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]