[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/7] qemu-option: Make qemu_opts_foreach() accum

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/7] qemu-option: Make qemu_opts_foreach() accumulate return values
Date: Wed, 03 Feb 2010 12:51:12 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/29/2010 12:48 PM, Markus Armbruster wrote:
Return the bitwise inclusive or of all return values instead of the
last call's value.  This lets you find out whether any of the calls
returned a non-zero value.

No functional change, as existing users either don't care for the
value, or pass non-zero abort_on_failure, which breaks the loop on the
first non-zero return value.

Signed-off-by: Markus Armbruster<address@hidden>

Applied all.  Thanks.

It's great to see you working on this. I'm really happy with how qdev has turned out but it desperately needs better online help.


Anthony Liguori

  qemu-option.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-option.c b/qemu-option.c
index 24392fc..a52a4c4 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -814,7 +814,7 @@ int qemu_opts_foreach(QemuOptsList *list, 
qemu_opts_loopfunc func, void *opaque,
      int rc = 0;

      QTAILQ_FOREACH(opts,&list->head, next) {
-        rc = func(opts, opaque);
+        rc |= func(opts, opaque);
          if (abort_on_failure&&   rc != 0)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]