[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] qemu-img: avoid preprocessor directives in a pr

From: Sheng Yang
Subject: [Qemu-devel] Re: [PATCH] qemu-img: avoid preprocessor directives in a printf call
Date: Thu, 4 Feb 2010 23:13:45 +0800
User-agent: KMail/1.12.2 (Linux/2.6.31-17-generic; KDE/4.3.2; x86_64; ; )

On Thursday 04 February 2010 21:29:40 Paolo Bonzini wrote:
> Other choices include using "(printf)", but this one is not bad in
> terms of readability.

This works well. :)

Acked-by: Sheng Yang <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

And there is two more...

One is:

readline.c:31:1: error: "printf" redefined
In file included from /usr/include/stdio.h:844,
                 from qemu-common.h:21,
                 from readline.h:4,
                 from readline.c:24:
/usr/include/bits/stdio2.h:65:1: error: this is the location of the previous 
make: *** [readline.o] Error 1

Of course, what you can see in readline.c is:

#define printf do_not_use_printf

I guess it's OK to remove this?

And there is last one in help() of vl.c...

After resolve these three, the build is fine now.

Paolo, could you address the other two issues as well in your patch? Thanks!

Yang, Sheng

reply via email to

[Prev in Thread] Current Thread [Next in Thread]