[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] QMP: Introduce the qmp_capabilities command

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2/4] QMP: Introduce the qmp_capabilities command
Date: Thu, 04 Feb 2010 17:40:33 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> This command will be used to enable QMP capabilities advertised
> by the capabilities array.
> Note that it will be mandatory to issue this command in order
> to make QMP functional (although this behavior is not being
> enforced yet).

The next commit enforces it.

> Also, as we don't have any capabilities yet, the new command
> doesn't accept any arguments. I will postpone the decision for
> a format for this until we get our first capability.

Fair enough.  Any argument we add to select capabilities after we ship
it this way will have to be optional, but that's okay.

> Finally, this command is visible from the user Monitor too, in
> the meaning that you can execute it but it won't do anything.
> Making it only visible in QMP is beyond this series' goal, as
> it requires changes in unrelated places.

We can fix this wart later.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]