|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging |
Date: | Thu, 04 Feb 2010 16:31:46 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 02/04/2010 02:13 PM, Luiz Capitulino wrote:
Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulino<address@hidden> --- qjson.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qjson.c b/qjson.c index 9ad8a91..0922c06 100644 --- a/qjson.c +++ b/qjson.c @@ -62,6 +62,7 @@ QObject *qobject_from_jsonf(const char *string, ...) obj = qobject_from_jsonv(string,&ap); va_end(ap); + assert(obj != NULL);
This is wrong. We may get JSON from an untrusted source. Callers need to deal with failure appropriately.
It just so happens that we only parse JSON from an untrusted source via qobject_from_json(), but the trust relationship is not obvious given the two functions in their current form.
Regards, Anthony Liguori
return obj; }
[Prev in Thread] | Current Thread | [Next in Thread] |