[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives |
Date: |
Fri, 05 Feb 2010 09:30:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 |
Am 05.02.2010 03:26, schrieb Sheng Yang:
> On Thursday 04 February 2010 23:49:55 Paolo Bonzini wrote:
>> Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the
>> other two problems by Sheng (tip: next time use "make -k" and
>> report all problems in a single message).
>>
>> Paolo Bonzini (4):
>> qemu-img: avoid preprocessor directives in a printf call
>> cope with printf macro definition in readline.c
>> do not interpolate % from vl.c to qemu-options.h
>> vl.c: avoid preprocessor directives in a printf call
>>
>> qemu-img.c | 9 +++++----
>> qemu-options.hx | 15 ++++++++-------
>> readline.c | 1 +
>> vl.c | 23 +++++++++--------------
>> 4 files changed, 23 insertions(+), 25 deletions(-)
>>
> Works fine with me. Thanks. :)
>
> But:
>
> diff --git a/vl.c b/vl.c
> index 39833fc..3d2de7b 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4041,14 +4041,7 @@ static void help(int exitcode)
> "\n"
> "When using -nographic, press 'ctrl-a h' to get some help.\n"
> ,
> - "qemu",
> - DEFAULT_RAM_SIZE,
> -#ifndef _WIN32
> - DEFAULT_NETWORK_SCRIPT,
> - DEFAULT_NETWORK_DOWN_SCRIPT,
> -#endif
> - DEFAULT_GDBSTUB_PORT,
> - "/tmp/qemu.log");
> + "qemu");
> exit(exitcode);
> }
>
> Is it proper to remove #ifndef _WIN32 there?
These lines are only moved into another #ifdef (in qemu-options.hx), so
this looks right to me.
Kevin
- [Qemu-devel] "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c, Sheng Yang, 2010/02/04
- [Qemu-devel] Re: "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c, Paolo Bonzini, 2010/02/04
- Re: [Qemu-devel] "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c, Jamie Lokier, 2010/02/04
- [Qemu-devel] Re: "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c, Juan Quintela, 2010/02/04
- [Qemu-devel] [PATCH 1/4] qemu-img: avoid preprocessor directives in a printf call, Paolo Bonzini, 2010/02/04
- [Qemu-devel] [PATCH 2/4] cope with printf macro definition in readline.c, Paolo Bonzini, 2010/02/04
- [Qemu-devel] [PATCH 3/4] do not interpolate % from vl.c to qemu-options.h, Paolo Bonzini, 2010/02/04
- [Qemu-devel] [PATCH 4/4] vl.c: avoid preprocessor directives in a printf call, Paolo Bonzini, 2010/02/04