[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount

From: Jim Meyering
Subject: [Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount
Date: Mon, 08 Feb 2010 16:32:57 +0100

Kevin Wolf wrote:
> I'm currently working on fixing exactly this, and unfortunaly, no, it's
> not that easy. What you introduce looks like proper error handling at
> first sight, but what happens in fact is that while the current write
> request correctly fails now we're running with corrupted metadata for
> all future requests (the new refcount table/block is already in use, but
> it has a refcount of 0 and will be overwritten sooner or later).
> Actually, I have found it impossible to fix the current approach, so the
> fix I'm working on will be more of a rewrite of the two functions.

Nicely worded NACK ;-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]