[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.
Date: Mon, 8 Feb 2010 18:27:53 +0200
User-agent: Mutt/1.5.19 (2009-01-05)

On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 11:17, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>>> initialize header type register in pci generic code.
>>> Cc: Blue Swirl<address@hidden>
>>> Cc: "Michael S. Tsirkin"<address@hidden>
>>> Signed-off-by: Isaku Yamahata<address@hidden>
>> No objections here, I am assuming this will be followed
>> by patches removing header type init from bridges?
>>  From qdev perspective, it is probably cleaner to make
>> multifunction bit a separate qdev property though, right?
> From a qdev perspective it would make *alot* of sense to move a bunch of 
> pci config stuff (including, but not limited to header type) into  
> PCIDeviceInfo.
> cheers,
>   Gerd

Actually - won't this make it possible to create broken configurations
by tweaking properties from command-line?
And generally, it sounds bad to have header type duplicated in qdev
and in config. Why do we want it in qdev?

Isaku Yamahata, could you please clarify?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]