[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Do not ignore error, if open file failed (-seri

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Do not ignore error, if open file failed (-serial /dev/tty)
Date: Wed, 10 Feb 2010 12:31:37 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/28/2010 12:44 PM, Evgeniy Dushistov wrote:
In case, when qemu is executed with option like
-serial /dev/ttyS0, report if there are problems with
opening of devices. At now errors are silently ignoring.

Signed-off-by: Evgeniy Dushistov<address@hidden>

Applied.  Thanks.


Anthony Liguori
  qemu-char.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index 800ee6c..75dbf66 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1180,6 +1180,9 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
      int fd;

      TFR(fd = open(filename, O_RDWR | O_NONBLOCK));
+    if (fd<  0) {
+        return NULL;
+    }
      tty_serial_init(fd, 115200, 'N', 8, 1);
      chr = qemu_chr_open_fd(fd, fd);
      if (!chr) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]