[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] add close callback for tty-based char device

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] add close callback for tty-based char device
Date: Wed, 10 Feb 2010 16:51:20 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 02/10/2010 04:00 PM, David Ahern wrote:
Add a tty close callback. Right now if a guest device that is connected
to a tty-based chardev in the host is removed, the tty is not closed.
With this patch it is closed.

Example use case is connecting an emulated USB serial cable in the guest
to ttyS0 of the host using the monitor command:

usb_add serial::/dev/ttyS0

and then removing the device with:

usb_del serial::/dev/ttyS0

Signed-off-by: David Ahern<address@hidden>
  qemu-char.c |   15 +++++++++++++++
  1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index 75dbf66..77edec9 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1173,6 +1173,20 @@ static int tty_serial_ioctl(CharDriverState *chr, int 
cmd, void *arg)
      return 0;

+static void qemu_chr_close_tty(CharDriverState *chr)
+    FDCharDriver *s = chr->opaque;
+    int fd = -1;
+    if (s)
+        fd = s->fd_in;

You've got trailing spaces and this doesn't adhere to CODING_STYLE (needs curly braces around the if clause).


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]