[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X
From: |
Rusty Russell |
Subject: |
[Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X |
Date: |
Fri, 12 Feb 2010 20:17:55 +1030 |
User-agent: |
KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; i686; ; ) |
On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> This documents MSI-X support in virtio.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Wow, great!
I reworked one paragraph for better grammar. Mainly adding "the":
(pseudo-patch):
Devices report such failures by returning +the+ NO_VECTOR value
when the relevant Vector field is read. After mapping an event to vector,
+the+ driver must verify success by reading the Vector field value: on
success, +the+ previously written value is returned-;-+, and+ on failure,
NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.
I really liked the conversational style: standards can be intimidating and
unfriendly documents if they concentrate too much on partitioning all
information into precise sections.
That makes it 0.8.6. I will re-read the entire document for consistency
before releasing 0.9.
Thanks!
Rusty.