[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block
Date: Fri, 19 Feb 2010 15:13:30 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 02/15/2010 10:19 AM, Kevin Wolf wrote:
The current implementation of alloc_refcount_block and grow_refcount_table has
fundamental problems regarding error handling. There are some places where an
I/O error means that the image is going to be corrupted. I have found that the
only way to fix this is to completely rewrite the thing.

Just sending as an RFC to the list hasn't generated a lot of comments (to be
precise, not a single one). This is a critical part of qcow2 and needs reviews.
So let's try it another way: People in CC, please give it a review. Sooner or
later some of you will need to do so anyway.

Should I apply this series?  I still don't see any review comments.


Anthony Liguori

Kevin Wolf (3):
   qcow2: Factor next_refcount_table_size out
   qcow2: Rewrite alloc_refcount_block/grow_refcount_table
   qcow2: More check for qemu-img check

  block/qcow2-refcount.c |  334 +++++++++++++++++++++++++++++++++++-------------
  1 files changed, 244 insertions(+), 90 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]