[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] json-parser: Fix segfault on malformed input
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH] json-parser: Fix segfault on malformed input |
Date: |
Wed, 24 Feb 2010 16:17:58 +0100 |
If the parser fails to parse the key in parse_pair, it will access a NULL
pointer. A simple way to trigger this is sending {foo} via QMP. This patch
turns the segfault into a syntax error reply.
Signed-off-by: Kevin Wolf <address@hidden>
---
json-parser.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index f3debcb..579928f 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -264,7 +264,7 @@ static int parse_pair(JSONParserContext *ctxt, QDict *dict,
QList **tokens, va_l
peek = qlist_peek(working);
key = parse_value(ctxt, &working, ap);
- if (qobject_type(key) != QTYPE_QSTRING) {
+ if (!key || qobject_type(key) != QTYPE_QSTRING) {
parse_error(ctxt, peek, "key is not a string in object");
goto out;
}
--
1.6.6.1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] json-parser: Fix segfault on malformed input,
Kevin Wolf <=