[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] scsi: Make device scsi-disk reject /dev/sg*

From: Markus Armbruster
Subject: [Qemu-devel] Re: [PATCH] scsi: Make device scsi-disk reject /dev/sg*
Date: Thu, 25 Feb 2010 12:58:14 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Gerd Hoffmann <address@hidden> writes:

> On 02/25/10 11:23, Markus Armbruster wrote:
>> You're supposed to use scsi-generic for that.  Which rejects anything
>> but /dev/sg*.
> Well, it isn't *that* easy.  The SG_IO ioctl used by scsi-generic
> works on tons of devices in linux, not only /dev/sg*.  I've seen

Yes, the existing check in scsi-generic is pretty cheesy.  My patch just
makes scsi-disk consistently cheesy ;)

> patches floading around which change the check bdrv_is_sg() into "try
> SG_IO and see if it works", which would allow to use /dev/sda with
> both scsi-disk and scsi-generic depending on what you want.  Which
> makes alot of sense.
> Making that change needs some extra care though to avoid existing
> configurations switching from scsi-disk to scsi-generic unnoticed.

Would be nice to have some day.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]