[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h
Date: Thu, 25 Feb 2010 13:50:56 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

On 02/25/2010 12:40 PM, Michael S. Tsirkin wrote:
On Thu, Feb 18, 2010 at 11:28:14PM +0200, Blue Swirl wrote:
     /* restore global registers */
-#include "hostregs_helper.h"
+    asm("");
+    env = (void *) saved_env_reg;

Is this sufficient?
I see __asm__ __volatile__("": : :"memory") in virtio.
Is memory clobber implied? What about volatile?

All asms without colons ("old-style") are volatile. Clobbering memory is not necessary since we are only caring about blocking assignments of "env", which is by definition in a register (hostregs_helper.h wasn't clobbering memory either).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]