[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newlin

From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH RFC 13/48] error: Make qemu_error() add a newline, strip it from arguments
Date: Fri, 26 Feb 2010 16:44:28 -0300

On Wed, 24 Feb 2010 18:55:25 +0100
Markus Armbruster <address@hidden> wrote:

> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
> There's one place that passes arguments without newlines
> intentionally: load_vmstate().  Fix it up.

 I'm not a big fun of printing functions that add automatic newline,
specially in C. But I understand that you're doing this because you're
going to prefix some info to the printed string.

 In this case, you could rename the function to qemu_error_nl(). Or at
least document it properly in the function definition.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]