[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infr
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure |
Date: |
Sat, 27 Feb 2010 19:49:23 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Feb 27, 2010 at 04:33:02PM +0100, Aurelien Jarno wrote:
> On Tue, Feb 02, 2010 at 04:49:02PM +0800, Liu Yu wrote:
> > It's convinent to use rom to checking overlap, to reset etc.
> > And uImage and ramdisk loading has already moved to it.
> >
> > Also, after we add fdt to rom, free it.
>
> This does not build if CONFIG_FDT is not set:
>
> | CC ppc-softmmu/ppc440_bamboo.o
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c: In function
> 'bamboo_load_device_tree':
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: 'ret' undeclared
> (first use in this function)
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: (Each undeclared
> identifier is reported only once
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:86: error: for each function it
> appears in.)
> | cc1: warnings being treated as errors
> | /home/aurel32/git/qemu/hw/ppc440_bamboo.c:36: error: unused variable 'fdt'
> | make[1]: *** [ppc440_bamboo.o] Error 1
> | make: *** [subdir-ppc-softmmu] Error 2
>
As I have pushed the patch by mistake to the git tree, and it is mostly
ok, I have committed a patch to fix the above issue.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net