[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 02/10] slirp: check system() success
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 02/10] slirp: check system() success |
Date: |
Thu, 4 Mar 2010 11:20:24 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Mar 04, 2010 at 10:00:31AM +0100, Juan Quintela wrote:
> we shouldn't call W*() macros until we check that fork worked.
>
> Signed-off-by: Juan Quintela <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> net/slirp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 317cca7..7f846ec 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s)
> if (s->smb_dir[0] != '\0') {
> snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir);
> ret = system(cmd);
> - if (!WIFEXITED(ret)) {
> + if (ret == -1 || !WIFEXITED(ret)) {
> qemu_error("'%s' failed.\n", cmd);
> } else if (WEXITSTATUS(ret)) {
> qemu_error("'%s' failed. Error code: %d\n",
> --
> 1.6.6.1
>
>
- [Qemu-devel] [PATCH v2 00/10] FORTIFY_SOURCE followup, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 02/10] slirp: check system() success, Juan Quintela, 2010/03/04
- [Qemu-devel] Re: [PATCH 02/10] slirp: check system() success,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 01/10] cow: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 06/10] vmdk: make vmdk_snapshot_create return -errno, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 07/10] vmdk: fix double free, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 08/10] vmdk: share cleanup code, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 09/10] block: print errno on error, Juan Quintela, 2010/03/04
- [Qemu-devel] [PATCH 10/10] documentation: qemu_write_full don't work with non-blocking fd's, Juan Quintela, 2010/03/04