|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists |
Date: | Thu, 11 Mar 2010 15:39:55 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 |
On 03/11/2010 02:58 PM, Paul Brook wrote:
On 03/11/2010 01:57 PM, Paul Brook wrote:+struct QEMUNotifier+{ + void (*notify)(QEMUNotifier *notifier); +};I suggest combining this with QEMUBH.I didn't understand this suggestion exactly, but I think it's related that I didn't understand the advantage of making QEMUNotifier a struct.My point is that we already have a mechanism for providing event notification callbacks, specifically QEMUBH. Why invent a new one?
QEMUBH seems seriously overengineered for this simple task. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |