[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers |
Date: |
Sat, 13 Mar 2010 03:55:25 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote:
> Signed-off-by: Avi Kivity <address@hidden>
> ---
> CODING_STYLE | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index a579cb1..92036f3 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -49,6 +49,9 @@ and is therefore likely to be changed.
> Typedefs are used to eliminate the redundant 'struct' keyword. It is the
> QEMU coding style.
>
> +When wrapping standard library functions, use the prefix qemu_ to alert
> +readers that they are seeing a wrapped version; otherwise avoid this prefix.
> +
> 4. Block structure
>
> Every indented statement is braced; even if the block contains just one
Not sure what "standard library functions" includes but I think the
qemu prefix should be allowed whenever one needs to wrap external
code blocks into qemu.
I don't feel very strongly about this though. I can call my stuff
wrap_xxx if I need to :)
Cheers,
Edde
- Re: [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists, (continued)
- Re: [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists, Avi Kivity, 2010/03/11
- Re: [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists, Anthony Liguori, 2010/03/11
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Markus Armbruster, 2010/03/11
- [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Juan Quintela, 2010/03/11
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Aurelien Jarno, 2010/03/12
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Paul Brook, 2010/03/12
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers,
Edgar E. Iglesias <=
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Avi Kivity, 2010/03/13
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Edgar E. Iglesias, 2010/03/13
- Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers, Anthony Liguori, 2010/03/22