|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PATCH, RFC] Replace assert(0) with abort() or cpu_abort() |
Date: | Mon, 15 Mar 2010 08:25:25 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Blue Swirl <address@hidden> writes: > When building with -DNDEBUG, assert(0) will not stop execution > so it must not be used for abnormal termination. For each case: are you sure the code does not recover after assert(0)? Not saying it does, just asking whether you checked. > Use cpu_abort() when in CPU context, abort() otherwise. I sympathize with the general idea, but I don't like dead code after abort(). What about cleaning that up?
[Prev in Thread] | Current Thread | [Next in Thread] |