Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.

[Stuart Brady]

On Sat, Feb 20, 2010 at 11:46:06AM -0800, Richard Henderson wrote:
> Delete inline functions from tcg-target.h that don't need to be there,
> move the others to tcg-target.c.  Add 'Z', 'I', 'J' constraints for
> 0, signed 11-bit, and signed 5-bit respectively.  Add 'c' constraint
> for RET1 register.  Add GUEST_BASE support similar to ppc64, with the
> value stored in a register.  Add missing registers to reg_alloc_order.
> Add support for 12-bit branch relocations.  Add functions for synthetic
> operations: addi, mtctl, dep, shd, vshd, ori, andi, shifts, rotates,
> multiply, millicode calls, branches, setcond.  Split out TLB reads from
> qemu_ld and qemu_st; fix argument loading for tlb external calls.
> Generate the prologue.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Acked-by: Stuart Brady <address@hidden>

I suppose you'd normally have split this into smaller patches, which
would make reviewing easier, but there's hardly any risk of regressions,
here.  I'm away from my HPPA box for a few weeks, so can't really test,
but I can't see anything obviously wrong.

I'll try to read through this a little more thoroughly at a later date,
but this patch certainly can't make matters any worse than they are...
(Bearing in mind that the half-finished HPPA support was written fairly
soon after the move to TCG and wasn't substantially updated since!)

The tcg_reg_free() calls worry me slightly, but I assume they're safe...
-- 
Stuart Brady