[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports
From: |
Jamie Lokier |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same. |
Date: |
Fri, 26 Mar 2010 04:08:42 +0000 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Amit Shah wrote:
> On (Fri) Mar 26 2010 [01:09:23], Jamie Lokier wrote:
> > Amit Shah wrote:
> > > The number of ports on the source as well as the destination machines
> > > should match. If they don't, it means some ports that got hotplugged on
> > > the source aren't instantiated on the destination. Or that ports that
> > > were hot-unplugged on the source are created on the destination.
> >
> > Surely the set of guest-visible ids must match exactly and be checked
> > (maybe mapped, if they were given in a different order), in which case
> > counting the number of ports looks redundant.
> >
> > I.e. is this check hiding the omission of the proper one?
>
> Yes, That's added in a later patch (5). That patch changes the guest
> abi, so it's separate.
>
> Also, patch 3 checks if all the ports on the src are present on the
> dest.
Great, thanks :-)
-- Jamie
- [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, (continued)
- [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Luiz Capitulino, 2010/03/26
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Amit Shah, 2010/03/26
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Luiz Capitulino, 2010/03/26
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Amit Shah, 2010/03/26
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Luiz Capitulino, 2010/03/26
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Amit Shah, 2010/03/27
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Luiz Capitulino, 2010/03/29
- Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add, Anthony Liguori, 2010/03/26
- Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same., Jamie Lokier, 2010/03/25
- Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same., Amit Shah, 2010/03/25
- Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same.,
Jamie Lokier <=