[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strang
From: |
Jamie Lokier |
Subject: |
Re: [Qemu-devel] Re: [PATCH 1/5] linux-user/ia64: workaround ia64 strangenesses |
Date: |
Tue, 30 Mar 2010 01:00:39 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Aurelien Jarno wrote:
> On Mon, Mar 29, 2010 at 11:36:50AM +0200, Paolo Bonzini wrote:
> >
> >> +#ifdef __ia64
> >> + sigprocmask(SIG_SETMASK, (sigset_t *)&uc->uc_sigmask, NULL);
> >> +#else
> >> sigprocmask(SIG_SETMASK,&uc->uc_sigmask, NULL);
> >> +#endif
> >
> > Any reason for the ifdef?
> >
>
> It is not strictly needed, as all architectures can cope with the ia64
> version. I have added it to make sure that a new architecture triggers a
> warning if uc->uc_sigmask is not of type sigset_t, so that a human can
> verify the cast is correct.
What type is the ia64 uc_sigmask, if not sigset_t?
A git grep of the kernel found only:
arch/ia64/include/asm/ucontext.h:#define uc_sigmask uc_mcontext.sc_sigmask
with sc_sigmask not defined anywhere. The uc_mcontext.sc_mask field,
though, is a sigset_t.
-- Jamie
[Qemu-devel] [PATCH 5/5] tcg: initial ia64 support, Aurelien Jarno, 2010/03/28
[Qemu-devel] [PATCH 3/5] ia64 disas support, Aurelien Jarno, 2010/03/28