[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] Add guest_start_len_valid function.
|
From: |
malc |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/7] Add guest_start_len_valid function. |
|
Date: |
Mon, 5 Apr 2010 22:41:53 +0400 (MSD) |
|
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Mon, 5 Apr 2010, Richard Henderson wrote:
> On 04/05/2010 11:15 AM, malc wrote:
> > Please do not use double leading underscore.
>
> In contrast to the existing use in:
>
> >> #define h2g_valid(x) ({ \
> >> unsigned long __guest = (unsigned long)(x) - GUEST_BASE; \
>
> What do you suggest instead? Trailing underscores?
Yes, the code is not C++ so trailing underscores will do.
--
mailto:address@hidden
- [Qemu-devel] [PATCH 0/7] Fix tests for start+len address valid for guest, Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 1/7] target-sparc: Fix TARGET_{PHYS, VIRT}_ADDR_SPACE_BITS., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 7/7] Use guest_start_len_valid in page_check_range., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 3/7] linux-user: Use guest_start_len_valid in msync., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 6/7] Fix zero-length write(2)., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 2/7] Add guest_start_len_valid function., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 5/7] linux-user: Use guest_start_len_valid in mmap., Richard Henderson, 2010/04/05
- [Qemu-devel] [PATCH 4/7] linux-user: Use guest_start_len_valid in mremap., Richard Henderson, 2010/04/05