[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: split raw_getlength
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: split raw_getlength |
|
Date: |
Tue, 06 Apr 2010 11:36:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 |
Am 05.04.2010 16:12, schrieb Christoph Hellwig:
> Split up the raw_getlength into separate generic, solaris and BSD
> versions to reduce the ifdef maze a bit. The BSD variant still
> is a complete maze, but to clean it up properly we'd need some
> people using the BSD variants to figure out what code is used
> for what variant.
>
> Signed-off-by: Christoph Hellwig <address@hidden>
Seems to leave some duplicate #ifdef CONFIG_BSD around, but that code is
a mess anyway and maybe it's the bit of additional ugliness that makes
someone of the BSD people clean it up. Anyway, it's definitely an
improvement over the current code.
Acked-by: Kevin Wolf <address@hidden>