qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2/2] block: Fix multiwrite memory leak in error case


From: Kevin Wolf
Subject: [Qemu-devel] [PATCH 2/2] block: Fix multiwrite memory leak in error case
Date: Tue, 6 Apr 2010 18:24:07 +0200

Previously multiwrite_user_cb was never called if a request in the multiwrite
batch failed right away because it did set mcb->error immediately. Make it look
more like a normal callback to fix this.

Reported-by: Juan Quintela <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
 block.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index ae5aba3..ed4c819 100644
--- a/block.c
+++ b/block.c
@@ -1893,7 +1893,8 @@ int bdrv_aio_multiwrite(BlockDriverState *bs, 
BlockRequest *reqs, int num_reqs)
                 reqs[i].error = -EIO;
                 goto fail;
             } else {
-                mcb->error = -EIO;
+                mcb->num_requests++;
+                multiwrite_cb(mcb, -EIO);
                 break;
             }
         } else {
-- 
1.6.6.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]