[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to QObject/QMP
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to QObject/QMP |
Date: |
Fri, 9 Apr 2010 14:25:54 -0300 |
On Thu, 8 Apr 2010 17:16:17 -0300
Miguel Di Ciurcio Filho <address@hidden> wrote:
> The VLANClientState structure has the member info_str, a simple string that
> is filled with information about NIC devices and used on monitor calls.
>
> There is no coherent formatting of this string by all the NIC devices,
> making it difficult to parse and represent this information over QMP.
>
> Patch 01 adds a new function qdict_to_qstring().
>
> Patch 02 replaces the function qemu_nic_format_info_str by
> qemu_nic_format_info_dict, adds a new QDict member to
> VLANClientState named info_dict.
>
> Patches 03-21 updates all devices to feed information into the new QDict.
>
> Patch 22 converts the 'info network' monitor command to QObject, enabling QMP
> support.
This series has a number of small things to improve, but seems the right
approach to me and in general looks very good. I'll followup individual
patches.
Two issues:
1. The following sequence triggers an assert()
(qemu) netdev_add user,id=foo
(qemu) info network
The netdev_add command is available in my tree (see below).
2. The last patch conflicts with patches from Markus, you can
rebase against my tree to solve that:
git://repo.or.cz/qemu/qmp-unstable.git
- [Qemu-devel] [PATCH 16/22] net: xilinx_ethlite: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, (continued)
- [Qemu-devel] [PATCH 16/22] net: xilinx_ethlite: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] [PATCH 18/22] net: slirp: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] [PATCH 19/22] net: socket: replace qemu_format_nic_info_str by qemu_format_nic_info_dict, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] [PATCH 20/22] net: tap: replace qemu_format_nic_info_str by info_dict, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] [PATCH 21/22] net: vde: replace qemu_format_nic_info_str by info_dict, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] [PATCH 22/22] monitor/net: Convert do_info_network() to QObject/QMP, Miguel Di Ciurcio Filho, 2010/04/08
- [Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to QObject/QMP,
Luiz Capitulino <=