[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the fi
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the file protocol |
|
Date: |
Wed, 14 Apr 2010 19:36:48 +0100 |
On Wed, Apr 14, 2010 at 4:50 PM, Kevin Wolf <address@hidden> wrote:
> +static int raw_set_locked(BlockDriverState *bs, int locked)
> +{
> + RAWState *s = bs->opaque;
> + bdrv_set_locked(s->hd, locked);
> + return 0;
> +}
Not something for this patch, but it's odd that
BlockDriver->bdrv_set_locked() has a return value but global
bdrv_set_locked() doesn't.
Stefan
- [Qemu-devel] [RFC PATCH 0/5] block: Format/protocol split, Kevin Wolf, 2010/04/14
- [Qemu-devel] [RFC PATCH 2/5] block: Split bdrv_open, Kevin Wolf, 2010/04/14
- [Qemu-devel] [RFC PATCH 3/5] block: Avoid forward declaration of bdrv_open_common, Kevin Wolf, 2010/04/14
- [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the file protocol, Kevin Wolf, 2010/04/14
- Re: [Qemu-devel] [RFC PATCH 1/5] block: separate raw images from the file protocol,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC PATCH 5/5] block: bdrv_has_zero_init, Kevin Wolf, 2010/04/14
- [Qemu-devel] [RFC PATCH 4/5] block: Open the underlying image file in generic code, Kevin Wolf, 2010/04/14