qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -de


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm
Date: Tue, 20 Apr 2010 09:28:22 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

  Hi,

Not much traffic on this thread ;-)

Indeed ;)

I can see the usefulness of an init_late() to generalize post device setup 
issues.
I assume then that you didn't have any other issues with my patch, other than 
general code structure concerns?

Yes, that is the major one. I think it is much saner to just have a init_late() and collect everything there instead of creating a new hook each time you figure you need one.

I think this also allows to make the ide changes less intrusive as all the cmos setup logic stays local to pc.c. pc.c can simply keep a pointer to the DeviceState structs of the ide interface(s) created in pc_init1(). pc_init_late() then can check which drives are plugged in and update cmos accordingly.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]