Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

[Anthony Liguori]

On 04/23/2010 08:28 AM, Kevin Wolf wrote:
> Am 23.04.2010 14:52, schrieb Michael Tokarev:
>    
> > Kevin Wolf wrote:
> >      
> > > Am 22.04.2010 11:52, schrieb Markus Armbruster:
> > >        
> > > > Michael Tokarev<address@hidden>  writes:
> > > >
> > > >          
> > > > > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
> > > > > (with fprintf) something like this:
> > > > >
> > > > >            
> > []
> >      
> > > > >       TFR(fd = open("/dev/net/tun", O_RDWR));
> > > > >       if (fd<  0) {
> > > > > -        fprintf(stderr, "warning: could not open /dev/net/tun: no virtual network 
> > > > > emulation\n");
> > > > > +        qemu_error("could not open /dev/net/tun: %m\n");
> > > > >           return -1;
> > > > >            
> > > I'm not sure where this %m is defined exactly (Linux specific? Maybe
> > > BSDs, too?), but it doesn't seem to work with mingw.
> > >        
> > The file being patched is tap-linux.c.
> > I noted this in my first email.
> >      
> Sorry, I missed that. You're right, of course.
>    

But from a consistency perspective, "%s", strerror(errno) would be nicer 
even if it's technically okay.

Regards,

Anthony Liguori

> Kevin
>
>
>
>