[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit'
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit' |
Date: |
Tue, 27 Apr 2010 10:20:08 -0300 |
On Tue, 27 Apr 2010 13:52:29 +0200
Paolo Bonzini <address@hidden> wrote:
> On 04/26/2010 09:44 PM, Luiz Capitulino wrote:
> > + qemu_system_exit_request();
>
> Untested suggestion: why add qemu_system_exit_request, exit_requested,
> and a hook in the main loop? You can do instead
>
> no_shutdown = 0;
> qemu_system_shutdown_request();
>
> which will actually call quit_timers() and net_cleanup() properly unlike
> a blind exit(0).
Hm, this looks good. It has the side effect of emitting the SHUTDOWN
event, but maybe this is even desirable.
I will send a patch if there are no objections.
> Alternatively, just give an error when "quit"-ting from QMP and keep the
> current behavior for non-QMP. This way you do not provide two ways to
> do the same thing. People will have to avoid -no-shutdown (I don't see
> how it is useful from QMP) and they will be able to use the "shutdown"
> monitor command.
Not sure if I got you here, why should we return an error?
- [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', (continued)
- [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- Re: [Qemu-devel] [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Jan Kiszka, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Anthony Liguori, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Luiz Capitulino, 2010/04/26
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Paolo Bonzini, 2010/04/27
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit',
Luiz Capitulino <=
- [Qemu-devel] Re: [PATCH 5/9] Monitor: Return before exiting with 'quit', Paolo Bonzini, 2010/04/27
[Qemu-devel] [PATCH 6/9] monitor: Cleanup ID assignment for compat switch, Luiz Capitulino, 2010/04/26
[Qemu-devel] [PATCH 7/9] monitor: Reorder intialization to drop initial mux focus, Luiz Capitulino, 2010/04/26
[Qemu-devel] [PATCH 8/9] chardev: Document mux option, Luiz Capitulino, 2010/04/26
[Qemu-devel] [PATCH 9/9] stash away SCM_RIGHTS fd until a getfd command arrives, Luiz Capitulino, 2010/04/26
Re: [Qemu-devel] [PATCH 0/9][PULL]: QMP/Monitor queue, Anthony Liguori, 2010/04/26