qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread up


From: Amit Shah
Subject: [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification
Date: Wed, 28 Apr 2010 12:59:21 +0530
User-agent: Mutt/1.5.19 (2009-01-05)

On (Tue) Apr 27 2010 [12:41:27], Anthony Liguori wrote:
> On 04/27/2010 07:34 AM, Amit Shah wrote:
>> From: Marcelo Tosatti<address@hidden>
>>
>> Wake up iothread when buffers are consumed.
>>
>> Signed-off-by: Marcelo Tosatti<address@hidden>
>> Signed-off-by: Amit Shah<address@hidden>
>>    
>
> What's the race here?  This looks very odd to me.

When the guest indicates it has added buffers to the vq, the iothread
can then start consuming them. Without this notification, the iothread
only polls for free buffers when it times out or gets woken up
otherwise.

Other virtio devices do it similarly as well.

                Amit




reply via email to

[Prev in Thread] Current Thread [Next in Thread]