[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread up
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification |
Date: |
Wed, 28 Apr 2010 12:59:21 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Apr 27 2010 [12:41:27], Anthony Liguori wrote:
> On 04/27/2010 07:34 AM, Amit Shah wrote:
>> From: Marcelo Tosatti<address@hidden>
>>
>> Wake up iothread when buffers are consumed.
>>
>> Signed-off-by: Marcelo Tosatti<address@hidden>
>> Signed-off-by: Amit Shah<address@hidden>
>>
>
> What's the race here? This looks very odd to me.
When the guest indicates it has added buffers to the vq, the iothread
can then start consuming them. Without this notification, the iothread
only polls for free buffers when it times out or gets woken up
otherwise.
Other virtio devices do it similarly as well.
Amit
- [Qemu-devel] [PATCH v6 12/18] iov: Add iov_to_buf and iov_size helpers, (continued)
- [Qemu-devel] [PATCH v6 12/18] iov: Add iov_to_buf and iov_size helpers, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 13/18] virtio-serial: Handle scatter-gather buffers for control messages, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 14/18] virtio-serial: Handle scatter/gather input from the guest, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 15/18] virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 16/18] virtio-serial: Discard data that guest sends us when ports aren't connected, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 17/18] virtio-serial: Implement flow control for individual ports, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Amit Shah, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Marcelo Tosatti, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification,
Amit Shah <=
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Amit Shah, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports, Amit Shah, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports, Anthony Liguori, 2010/04/28
[Qemu-devel] Re: [PATCH v6 01/18] virtio-serial: save/load: Ensure target has enough ports, Anthony Liguori, 2010/04/28