Re: [Qemu-devel] simple block driver cleanups

[Kevin Wolf]

Am 04.05.2010 15:22, schrieb Christoph Hellwig:
> On Tue, May 04, 2010 at 02:38:07PM +0200, Kevin Wolf wrote:
>> Am 04.05.2010 12:43, schrieb Christoph Hellwig:
>>> This series cleans up the simple read-only block drivers to use the
>>> qemu block device API to access their backing devices, making the code
>>> simpler and usable over nbd/curl.  I've not touched dmg yet as it's even
>>> more bitrot than usual and deserves it's own series.
>>
>> Have you already added something to qemu-iotests locally to test this or
>> did you test manually?
> 
> I tested cloop manually, I haven't found usable creation tools for the
> others yet.

Okay, so I have reviewed the patches now and except for that one thing
in parallels they look good.

For cloop I trust your test, and for bochs I did a very basic test
myself (however, I doubt that anyone uses this driver, considering how
hard it is to create such an image...). For parallels I still need to
find out how to create an image.

I've applied cloop and bochs to the block branch, and I'll wait for a v2
with the parallels patches.

Kevin