Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

[Gerd Hoffmann]

On 05/11/10 11:25, Markus Armbruster wrote:
> Alex Williamson<address@hidden>  writes:
>
> > If the init function of a device fails, as might happen with device
> > assignment, we never undo the work done by do_pci_register_device().
> > This not only causes a bit of a memory leak, but also leaves a bogus
> > pointer in the bus devices array that can cause a segfault or
> > garbage data from 'info pci'.
> >
> > Signed-off-by: Alex Williamson<address@hidden>
>
> Looks good to me.  Gerd?

Yes, looks fine.

cheers,
  Gerd