qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] Create shared-obj-y


From: Juan Quintela
Subject: [Qemu-devel] Re: [PATCH 1/2] Create shared-obj-y
Date: Tue, 11 May 2010 14:17:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Kevin Wolf <address@hidden> wrote:
> Am 11.05.2010 13:13, schrieb Juan Quintela:
>> This variable contains the objects shared between tools and qemu binary.
>> Add qemu-error.o only in one place, it "could" be built in two places
>> depending of make ordering.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>
>> --- a/Makefile.objs
>> +++ b/Makefile.objs
>> @@ -39,16 +39,19 @@ fsdev-nested-$(CONFIG_LINUX) = qemu-fsdev.o
>>  fsdev-obj-$(CONFIG_LINUX) += $(addprefix fsdev/, $(fsdev-nested-y))
>> 
>>  ######################################################################
>> +# shared-obj-y has the object that are shared by qemu binary and tools
>> +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y)
>
> Currently, block-obj-y contains some more files which are not really
> related to the block layer, such as cutils.o or osdep.o. Should they be
> moved here while we're at it?

Agreed, I was just doing the "minimal" impact change.  block-obj-y was
the variable that fit better in old style.

Later, Juan.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]