[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation for o

From: Kevin Wolf
Subject: [Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation for odd disk sizes
Date: Wed, 12 May 2010 20:56:11 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

Am 12.05.2010 20:25, schrieb Stefan Weil:
> The fix is based on a patch from Kevin Wolf. Here his comment:
> "The number of blocks needs to be rounded up to cover all of the virtual hard
> disk. Without this fix, we can't even open our own images if their size is not
> a multiple of the block size."
> While Kevin's patch addressed vdi_create, my modification also fixes
> vdi_open which now accepts images with odd disk sizes.
> v3:
> Don't allow reading of disk images with too large disk sizes.
> Neither VBoxManage nor old versions of qemu-img read such images.
> This change requires rounding of odd disk sizes before we do the checks.
> Cc: Kevin Wolf <address@hidden>
> Cc: François Revol <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]