[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc
Date: Fri, 14 May 2010 20:02:28 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4

On 05/14/2010 08:01 PM, Avi Kivity wrote:
On 05/14/2010 07:52 PM, Jan Kiszka wrote:

In order not to compromise QMP adoption and make users' life easier,
this commit adds a simple text documentation which fully describes
all QMP supported commands.

This is not ideal for a number of reasons (harder to maintain,
text-only, etc) but does improve the current situation.
Even if it's temporary - maintaining it in a separate file looks rather

Can't we generate the per-command documentation snippets also from
qemu-monitor.hx and merge them with a header/footer into some text file?
That .hx file is the one anyone adding/converting commands has to touch

If we do, then the generated documentation should be included in the patch changelog for review.

I mean, a patch introducing or modifying a monitor command.

Do not meddle in the internals of kernels, for they are subtle and quick to 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]