[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc |
Date: |
Fri, 14 May 2010 19:03:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Avi Kivity <address@hidden> writes:
> On 05/14/2010 11:50 AM, Markus Armbruster wrote:
>>
>>>> +
>>>> +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
>>>>
>>>>
>>> Oh, we do have more.
>>>
>>> Please document the units for this value (bits per second)?
>>>
>> bytes per second?
>>
>
> Bandwidth is typically measured in bits per second.
The question is what unit the code actually uses. What it should use is
separate, if valid question.
>>>> +- "bus": identical to the parent's bus number (json-int)
>>>> +- "slot": slot number (json-int)
>>>> +- "function": function number (json-int)
>>>>
>>>>
>>> Would have been nicer as a nested object (list of buses, each
>>> containing a list of slots, each containing a list of functions).
>>>
>> We have a list of buses, each containing a list of device functions.
>> Not sure the additional level of nesting you propose buys us anything.
>>
>
> A slot is the hotpluggable entity. Open your computer and you can
> actually see them.
QEMU doesn't really know that.
> btw would be good to list empty slots as well.
Why?
> What about PCI domains?
Good point. Better to provide for them neatly now, instead of kludging
them in later.
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, (continued)
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/13
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Luiz Capitulino, 2010/05/13
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/13
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Luiz Capitulino, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/17
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/17
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/17
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Anthony Liguori, 2010/05/17
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Gerd Hoffmann, 2010/05/17
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/18
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Luiz Capitulino, 2010/05/14
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Avi Kivity, 2010/05/15
- Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc, Markus Armbruster, 2010/05/17