[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for s
|
From: |
Christoph Hellwig |
|
Subject: |
[Qemu-devel] Re: [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices |
|
Date: |
Sun, 16 May 2010 15:30:22 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Sat, May 15, 2010 at 06:30:59AM -0700, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <address@hidden>
>
> This patch adds a BlockDriverState->sg check in block.c:bdrv_common_open()
> to skip the new refresh_total_sectors() call once we know we are working with
> a scsi-generic device.
>
> We go ahead and skip this call for scsi-generic devices because
> block/raw-posix.c:raw_getlength() -> lseek() will return -ESPIPE.
How about moving that check into refresh_total_sectors?